announcements: Fix NewAnnouncementBanner & trigger notification on status update #5376
Conversation
|
Thanks for the contribution! |
Changed Packages
|
Signed-off-by: Hope Hadfield <[email protected]> Signed-off-by: Mattia <[email protected]>
….4 (backstage#5340) Signed-off-by: Renovate Bot <[email protected]> Co-authored-by: backstage-goalie[bot] <97962292+backstage-goalie[bot]@users.noreply.github.com> Signed-off-by: Mattia <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Mattia <[email protected]>
… v2.23.4 (backstage#5368) Signed-off-by: Renovate Bot <[email protected]> Co-authored-by: backstage-goalie[bot] <97962292+backstage-goalie[bot]@users.noreply.github.com> Signed-off-by: Mattia <[email protected]>
… status, navigate to root on edit complete Signed-off-by: Mattia <[email protected]>
matdtr
force-pushed
the
update-announcements
branch
from
82bcbe9 to
2463ab0
Compare
matdtr
requested review from
AndrienkoAleksandr,
PatAKnight,
christoph-jerolimov,
ciiay,
debsmita1,
divyanshiGupta,
dzemanov,
lholmquist and
logonoff
as code owners
matdtr
changed the title
| page?: number; | ||
| max?: number; | ||
| active?: boolean; | ||
| active?: string; |
There was a problem hiding this comment.
I would prefer to keep it as a boolean
| active?: string; | |
| active?: boolean; |
There was a problem hiding this comment.
Hi @gaelgoth, i do agree but on the GET path the backend receives the value as string that’s why the switch of type.
if kept as boolean it would fail as reported here #5235.
Let me know how you would like to address it, if revert the type or fix the tests.
PS.
Sorry maintainers not sure why all you got tagged in this PR.
There was a problem hiding this comment.
Aaah, I didn’t realize it was the endpoint query, which is always a string with express. That makes sense, let’s treat it as a string for the "external" type contract in the http query and update the tests accordingly.
I think the rebase ended up modifying some existing commits. Can you please fix this. Or totally fine to just spin up a fresh PR instead 👍🏾
There was a problem hiding this comment.
Fixed, created a new PR #5519. Will close this
gaelgoth
removed request for
christoph-jerolimov,
ciiay,
debsmita1,
divyanshiGupta and
dzemanov
4 participants
Hey, I just made a Pull Request!
Fixed handling of
activeprop in NewAnnouncementBannerExtended signal and notification on update when the annoucencement is activated
Updated
EditAnnoucementPageto navigate to root path as the announcement creation pageAll items reported in #5235
✔️ Checklist
Signed-off-byline in the message. (more info)